Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: reorder semantics guide to the bottom #10541

Merged
merged 4 commits into from
May 27, 2024
Merged

docs: reorder semantics guide to the bottom #10541

merged 4 commits into from
May 27, 2024

Conversation

yoonhyejin
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@yoonhyejin yoonhyejin requested review from hsheth2 and jjoyce0510 May 20, 2024 00:52
hsheth2
hsheth2 reviewed May 21, 2024
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the title of the page is still "But First, Semantics: Upsert versus Patch" - might want to change that

@yoonhyejin yoonhyejin requested a review from hsheth2 May 22, 2024 04:55
@yoonhyejin yoonhyejin merged commit e66cc70 into master May 27, 2024
33 checks passed
@yoonhyejin yoonhyejin deleted the docs/reorder-api-guide branch May 27, 2024 07:15
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@yoonhyejin @sleeperdeep
docs: reorder semantics guide to the bottom (datahub-project#10541)
18c13de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@jjoyce0510 jjoyce0510 Awaiting requested review from jjoyce0510

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoonhyejin @hsheth2